Check Type has parameters field with an element

JuliaDebug · Sep 1, 2023 · 5cd1923 · 5cd1923
1 parent a017a4d
commit 5cd1923
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/TypedSyntax/src/show.jl b/TypedSyntax/src/show.jl
@@ -99,7 +99,7 @@ function type_annotation_mode(node, @nospecialize(T); type_annotations::Bool, hi
     type_annotate = is_show_annotation(T; type_annotations, hide_type_stable)
     pre = pre2 = post = ""
     if type_annotate
-        if T isa Type && T <: Type
+        if T isa Type && T <: Type && T !== Union{} && isassigned(T.parameters, 1)
             # Don't annotate `String::Type{String}`
             if replace(sourcetext(node), r"\s" => "") == replace(sprint(show, T.parameters[1]), r"\s" => "")
                 return false, pre, pre2, post

diff --git a/TypedSyntax/test/runtests.jl b/TypedSyntax/test/runtests.jl
@@ -650,6 +650,16 @@ include("test_module.jl")
     @test_nowarn str = sprint(tsn; context=:color=>false) do io, obj
         printstyled(io, obj; hide_type_stable=false)
     end
+
+    # issue 491
+    tsn = TypedSyntaxNode(+, (Int, Int)) # need a node, not important what it is
+    @test_nowarn TypedSyntax.type_annotation_mode(tsn, Union{}; type_annotations=true, hide_type_stable=false)
+
+    # issue 492
+    tsn = TypedSyntaxNode(Base._tuple_unique_fieldtypes, (Any,))
+    @test_nowarn str = sprint(tsn; context=:color=>false) do io, obj
+        printstyled(io, obj; hide_type_stable=false)
+    end
 end
 
 if parse(Bool, get(ENV, "CI", "false"))