allow src.slottypes === nothing for unoptimized src
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On nightly Cthulhu.jl tries to generate `src.slottypes::Vector{Any}`
even when there is heavy recursion detected (xref #418), but it turns
out that `record_slot_assign!(sv)` works only when `sv.ssavaluetypes`
does not contain any `LimitedAccuracy`ies (#442).
Luckily, while working on #418, we added the support in TypedSyntax
for the `src.slottypes === nothing` case, so we can use it and remove
the code to generate `src.slottypes::Vector{Any}`
Fixes #442.
|
The failure is unrelated and caused by JuliaLang/julia#41099. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nightly Cthulhu.jl tries to generate
src.slottypes::Vector{Any}even when there is heavy recursion detected (xref #418), but it turns out thatrecord_slot_assign!(sv)works only whensv.ssavaluetypesdoes not contain anyLimitedAccuracyies (#442).Luckily, while working on #418, we added the support in TypedSyntax for the
src.slottypes === nothingcase, so we can use it and remove the code to generatesrc.slottypes::Vector{Any}Fixes #442.