Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type pirate the nop Some conversion fix #232

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Conversation

KristofferC
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #232 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   87.19%   87.14%   -0.05%     
==========================================
  Files          14       14              
  Lines        1944     1945       +1     
==========================================
  Hits         1695     1695              
- Misses        249      250       +1
Impacted Files Coverage Δ
src/JuliaInterpreter.jl 95% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b93e04...2ce4a8b. Read the comment docs.

@timholy timholy changed the title type pirate the nop Some conversion fix WIP: type pirate the nop Some conversion fix Mar 29, 2019
@timholy
Copy link
Member

timholy commented Mar 29, 2019

Note: do not merge until we get a version number from JuliaLang/julia#31536.

I'd advocate merging that Julia PR pretty quickly just so you can get the VERSION number here.

@KristofferC KristofferC force-pushed the KristofferC-patch-1 branch from 2ce4a8b to 3a8b1f3 Compare March 29, 2019 15:19
@KristofferC
Copy link
Member Author

Added VERSION

@KristofferC KristofferC changed the title WIP: type pirate the nop Some conversion fix type pirate the nop Some conversion fix Mar 29, 2019
@KristofferC KristofferC merged commit 2824793 into master Mar 29, 2019
@KristofferC KristofferC deleted the KristofferC-patch-1 branch March 29, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants