Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to upstream changes of Core.Compiler._findsup #529

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

aviatesk
Copy link
Member

Still we want to wait for the release of next beta version and change the version compat accordingly.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #529 (ec584e4) into master (f3b4c3d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   87.29%   87.40%   +0.11%     
==========================================
  Files          12       12              
  Lines        2472     2470       -2     
==========================================
+ Hits         2158     2159       +1     
+ Misses        314      311       -3     
Impacted Files Coverage Δ
src/utils.jl 88.23% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b4c3d...ec584e4. Read the comment docs.

@fredrikekre
Copy link
Contributor

I'm guessing this will fix this segfault on release-1.8?

julia> using JuliaInterpreter                                                                                                                                                                                                          
[ Info: Precompiling JuliaInterpreter [aa1ae85d-cabe-5617-a682-6adf51b2e16a]                                                                                                                                                           
                                                                                                                                                                                                                                       
signal (11): Segmentation fault                                                                                                                                                                                                        
in expression starting at /home/fredrik/.julia/packages/JuliaInterpreter/hNHlh/src/packagedef.jl:150                                                                                                                                   
ml_matches at /home/fredrik/julia18/src/gf.c:2824                                                                                                                                                                                      
_gf_invoke_lookup at /home/fredrik/julia18/src/gf.c:2552 [inlined]                                                                                                                                                                     
ijl_gf_invoke_lookup at /home/fredrik/julia18/src/gf.c:2564                                                                                                                                                                            
whichtt at /home/fredrik/.julia/packages/JuliaInterpreter/hNHlh/src/utils.jl:45                                                                                                                                                        
#prepare_call#43 at /home/fredrik/.julia/packages/JuliaInterpreter/hNHlh/src/construct.jl:240                                                                                                                                          
prepare_call##kw at /home/fredrik/.julia/packages/JuliaInterpreter/hNHlh/src/construct.jl:233 [inlined]

@aviatesk aviatesk changed the title update with https://github.com/JuliaLang/julia/pull/44515 adapt to upstream changes of Core.Compiler._findsup Mar 16, 2022
@aviatesk
Copy link
Member Author

aviatesk commented Mar 16, 2022

I'm guessing this will fix this segfault on release-1.8?

yes.

@aviatesk aviatesk merged commit 5a39c51 into master Mar 16, 2022
@aviatesk aviatesk deleted the avi/update branch March 16, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants