Don't error if we don't have line information #634
Conversation
`whereis` is already allowed to return `nothing`. It's possible for codeloc to be != 0, but for Core.Compiler to still be unable to produce a location. In that case, also return `nothing`.
Companion PR to JuliaDebug/LoweredCodeUtils.jl#107. With both of these and JuliaDebug/JuliaInterpreter.jl#634, basic Revise functionality is working for me again on Julia master.
| @@ -277,12 +277,14 @@ function linetable(arg) | |||
| return ci.linetable::Union{Vector{Core.LineInfoNode},Vector{Any}} # issue #264 | |||
| end # @static if | |||
| end | |||
| function linetable(arg, i::Integer; macro_caller::Bool=false)::Union{Expr,LineTypes} | |||
| function linetable(arg, i::Integer; macro_caller::Bool=false)::Union{Expr,Nothing,LineTypes} | |||
There was a problem hiding this comment.
linetable(arg, ::Integer) is used in the other places too, like linenumber(::FrameCode, pc), so better to handle the nothing case there too?
There was a problem hiding this comment.
I guess the other option would be to synthesize a special LineNumber node that indicates the absence of information. That way clients that don't care don't have to worry about it
There was a problem hiding this comment.
I like the nothing option since anything that isn't prepared will hard-error.
|
I've finished off the Also, it sure would be nice to have a test! I know they can be hard to capture, but there's a real sense in which JuliaInterpreter/Revise/etc work only because of their test suites. If we don't keep capturing that we become vulnerable to regressions. We also shouldn't be too optimistic that Revise will "work" once this is merged and a new LoweredCodeUtils is released; JuliaInterpreter tests still fail, and thus it's very likely that Revise will fail on certain files as a consequence. The difference in stepping on Julia 1.12 (#636) could absolutely break Revise. |
|
Thanks for the fix! |
Companion PR to JuliaDebug/LoweredCodeUtils.jl#107. With both of these and JuliaDebug/JuliaInterpreter.jl#634, basic Revise functionality is working for me again on Julia master.
Companion PR to JuliaDebug/LoweredCodeUtils.jl#107. With both of these and JuliaDebug/JuliaInterpreter.jl#634, basic Revise functionality is working for me again on Julia master. However, tests are still failing, so there will be more work needed for full functionality. Co-authored-by: Tim Holy <tim.holy@gmail.com>
whereisis already allowed to returnnothing. It's possible for codeloc to be != 0, but for Core.Compiler to still be unable to produce a location. In that case, also returnnothing.