fix interpretation of opaque closures on nightly #649
+4
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the best way I could think of to determine whether an OC contains inferred code after JuliaLang/julia#53219. Also deletes a fastpath we had for OCs containing inferred code in `maybe_evaluate_builtin` as it doesn't really seem necessary and we would otherwise scan the IR twice for OCs we do want to interpret.
simeonschaub
force-pushed
the
sds/fix_oc
branch
from
832fd5e
to
a842a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the best way I could think of to determine whether an OC
contains inferred code after JuliaLang/julia#53219. Also deletes a
fastpath we had for OCs containing inferred code in
maybe_evaluate_builtinas it doesn't really seem necessary and wewould otherwise scan the IR twice for OCs we do want to interpret.