Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to rules for norm #337

Merged
merged 22 commits into from
May 10, 2021
Merged

Improvements to rules for norm #337

merged 22 commits into from
May 10, 2021

Commits on May 7, 2021

  1. widen type of norm pullback, add inplace + tests

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    19578d6 View commit details
    Browse the repository at this point in the history

  2. tidy

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    9993979 View commit details
    Browse the repository at this point in the history

  3. allow, and test, integer x

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    6b6487d View commit details
    Browse the repository at this point in the history

  4. don't let broadcast allocate ∂x because it's weird

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    b03b83d View commit details
    Browse the repository at this point in the history

  5. one more

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    b666c37 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
    @mcabbott @simeonschaub
    mcabbott and simeonschaub committed May 7, 2021
    Configuration menu
    Copy the full SHA
    972b6dd View commit details
    Browse the repository at this point in the history

  7. + tests

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    c12b829 View commit details
    Browse the repository at this point in the history

  8. a type-stability fix via parent & re-wrap

    @mcabbott
    Michael Abbott authored and mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    e4d60f2 View commit details
    Browse the repository at this point in the history

  9. comments from review

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    96eafd6 View commit details
    Browse the repository at this point in the history

  10. restrict all arrays to eltype Number

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    07eb77b View commit details
    Browse the repository at this point in the history

  11. skip UpperHessenberg

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    d3833fc View commit details
    Browse the repository at this point in the history

  12. version

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    79ecf73 View commit details
    Browse the repository at this point in the history

  13. move branches into InplaceableThunk

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    f1b5ba4 View commit details
    Browse the repository at this point in the history

  14. give up on inplacethunk

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    3f893e4 View commit details
    Browse the repository at this point in the history

  15. try to find out where we are

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    46bf4c5 View commit details
    Browse the repository at this point in the history

  16. don't count the thunks

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    71d4ac9 View commit details
    Browse the repository at this point in the history

  17. rm nested unthunking

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    e400bd5 View commit details
    Browse the repository at this point in the history

  18. make tests pass

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    81f85b7 View commit details
    Browse the repository at this point in the history

  19. comments

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    43a2756 View commit details
    Browse the repository at this point in the history

  20. update notation

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    0331eda View commit details
    Browse the repository at this point in the history

  21. tidy

    @mcabbott
    mcabbott committed May 7, 2021
    Configuration menu
    Copy the full SHA
    69a92dc View commit details
    Browse the repository at this point in the history

  22. integer comment 

    Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
    @mcabbott @oxinabox
    mcabbott and oxinabox committed May 7, 2021
    Configuration menu
    Copy the full SHA
    87e4313 View commit details
    Browse the repository at this point in the history