-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DoesNotExist #262
Comments
I don't hate it enough to change it, but agree a different name would be better. I like |
|
|
xref: #305 |
A point against Because discrete spaces form 0-dimensional manifolds, then the tangent space (if it exists, not sure if it formally does) contains only the zero vector. So from this perspective |
#305 suggests calling this
In theory it might be nice for it to error if it is ever used (I.e. if it was ever added to a primal value). I like the difference between DoesNotExist and Zero is that if your primal output is discrete (like a bool) then it's differential will be Zero (almost everywhere), e.g. from |
done in #353 |
I hate the name
DoesNotExist
.To me 1st year calculs said things like "The derivative does not exist when the derivative when taking the limit from the left is not equal to the dervative when taking the limit from the right".
But infact for that case we often return
Zero
by the subgradient convention -- since it is a potential local minima.What we use
DoesNotExist
to signify is that: "perturbing this value is not well-defined, or would result in the primal program throwing an error"Which is for things like the integer index in
getindex
or forString
s.I think we should rename it to something like
NoTangentSpace
orNonPerturbable
.I like of like
CanNotLinearize()
but that is actually applicable for the limit from left != limit from right case.It looks like DexLang calls this Discrete
The text was updated successfully, but these errors were encountered: