-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming some things #305
Comments
Thanks for taking this seriously.
Definitely, all these renaming looks good. Since this is a big change that may affect packages depending on Add: at least the |
Yup, we would be sure to deprecate sensibly -- as you say, it would almost certainly break a lot of code! |
We will just make all the follow up PRs ourself. |
Following @GiggleLiu's enthusiasm for renaming
Composite
toTangent
in this Zygote issue, I think it might be a good time to consider doing some renaming. The impression I get is that usingTangent
in the names of things is probably a good idea, and could avoid some serious confusion.@oxinabox discussed this briefly on slack, and he made the following suggestions:
Composite
->CompositeTangent
(i.e. a tangent that's built out of other stuff)DoesNotExist
->NoPossibleTangent
Thunk
->ThunkedTangent
Zero
->ZeroTangent
We might also want to consider whether
AbstractDifferential
is a sensible name, or whether we want to rename that toAbstractTangent
or something.@GiggleLiu do these proposals seem intuitive?
Then there's the issue that we're actually using these to represent cotangents whenever we're doing reverse-mode, which hasn't seemed to be problematic so far. Maybe @sethaxen could comment on whether we want to take another look at this if we're doing some renaming?
The text was updated successfully, but these errors were encountered: