-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules for functions / structs etc #4
Comments
Won't this be necessary for things like the derivative of |
I am pretty sure this is actually closed. |
Not under normal uses no. |
There are two orthogonal issues here:
My feeling is that Zygote has got this 'right', and that we should support this functionality. Unfortunately this change requires some fairly dull work. |
The only remaining parts of this are covered by #8 |
* Add Documentation setup with Documenter This adds no actual documentation, only the infrastructure needed to set up and deploy documentation. * Remove testing on 0.7, add 1.1 In the REQUIRE file, the package declares itself to be compatible only with Julia 1.0 or higher, but 0.7 was still listed in CI. This removes 0.7 and adds 1.1. It also updates the coverage setup. * Add a Project.toml file These are indispensible for local development, and will soon be required anyway (for some definition of "soon"). * Add missing dependency on ForwardDiff to REQUIRE
The current design requires that rules have the form
I would like to propose to extend this to the following:
A lot of the time
rule_foo
will be a DNE, which is fine. However, if we're looking to implement rules for particularstruct
s, then it may well be important to be able to represent the gradient w.r.t. the fields of the struct.The text was updated successfully, but these errors were encountered: