Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AD demos on Julia nightly #299

Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix AD demos on Julia nightly #299

merged 2 commits into from
Feb 8, 2021

Conversation

simeonschaub
Copy link
Member

@simeonschaub simeonschaub commented Feb 8, 2021

This was broken by JuliaLang/julia#38136

@simeonschaub
Copy link
Member Author

simeonschaub commented Feb 8, 2021

Are we not testing on nightly currently?

@nickrobinson251
Copy link
Contributor

Are we not testing on nightly currently?

I thnk we're supposed to be (https://github.com/JuliaDiff/ChainRulesCore.jl/blob/decfca42702ff11a6c4b97c3563498e19415407a/.github/workflows/JuliaNightly.yml)

But doesn't look like it's actually running. Maybe @oxinabox knows what the situation is?

@simeonschaub
Copy link
Member Author

Ah, so it's not run on every PR, but instead just once per day on master. I think it would make sense to at least test nightly on one platform on every PR, so problems are noticed right away.

@nickrobinson251
Copy link
Contributor

I think it would make sense to at least test nightly on one platform on every PR, so problems are noticed right away.

opened #300 :)

@simeonschaub
Copy link
Member Author

simeonschaub commented Feb 8, 2021

How does CD here work nowadays? Should I bump the version as well and then register afterwards? Or do we now have a tool for that?

@oxinabox
Copy link
Member

oxinabox commented Feb 8, 2021

Should I bump the version as well and then register afterwards?

Yes, do that

@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #299 (df97168) into master (decfca4) will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   89.61%   87.85%   -1.76%     
==========================================
  Files          13       13              
  Lines         462      420      -42     
==========================================
- Hits          414      369      -45     
- Misses         48       51       +3     
Impacted Files Coverage Δ
src/differentials/thunks.jl 56.52% <0.00%> (-7.48%) ⬇️
src/ruleset_loading.jl 94.73% <0.00%> (-3.14%) ⬇️
src/differentials/composite.jl 79.80% <0.00%> (-2.65%) ⬇️
src/rule_definition_tools.jl 93.57% <0.00%> (-0.74%) ⬇️
src/accumulation.jl 96.66% <0.00%> (-0.40%) ⬇️
src/differentials/abstract_zero.jl 93.75% <0.00%> (-0.37%) ⬇️
src/differential_arithmetic.jl 96.15% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decfca4...df97168. Read the comment docs.

@simeonschaub simeonschaub merged commit 0726513 into master Feb 8, 2021
@simeonschaub simeonschaub deleted the sds/fix_demos branch February 8, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants