-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use StaticArraysCore #22
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 86.48% 86.84% +0.35%
==========================================
Files 1 1
Lines 74 76 +2
==========================================
+ Hits 64 66 +2
Misses 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Maybe this should be fixed upstream and one should open issue in StaticArraysCore? It seems the docstring for |
That would certainly minimise the diff here. But (1) that means a chain of 4 PRs to get ForwardDiff free, and (2) from a quick look it wasn't just a few lines to move In the meantime, are there any actual downsides to this approach? Simple tests seem so say |
I opened an issue (JuliaArrays/StaticArraysCore.jl#12), so let's maybe see at least what the maintainers of StaticArraysCore think. |
Apparently the plan is to move Size to StaticArraysCore within the next few days, so I guess it would be good to wait with this PR until that's done. |
|
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replaces StaticArrays with StaticArraysCore. Needed for JuliaDiff/ForwardDiff.jl#599
This means dropping Julia < 1.6.
There is a bit of a hack to get around the fact that
Size
isn't available. Looks like this is well-tested.