Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret preparation modifier for resizing #521

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Secret preparation modifier for resizing #521

merged 2 commits into from
Sep 30, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 30, 2024

First step of the solution to #519, creates the syntax but doesn't provide any optimized implementation.

DI source

  • Add secret functions prepare!_operator(f, other_prep, backend, x) which have the same output as prepare_operator(f, backend, x) but possibly modify the other_prep object to save memory, e.g. by resizing it if it came from an x2 with a different size.

DIT source

  • Add a modified preparation in the correctness tests. Right now it's not modified from an array of different size, just from the same array (it's a bit of a hassle to check that if we prepare from a smaller or larger array, the contexts also apply).

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (3f29b61) to head (cc4bc4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   98.71%   98.70%   -0.01%     
==========================================
  Files         105      106       +1     
  Lines        4525     4571      +46     
==========================================
+ Hits         4467     4512      +45     
- Misses         58       59       +1     
Flag Coverage Δ
DI 98.87% <100.00%> (-0.03%) ⬇️
DIT 98.35% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Secret preparation modifier Secret preparation modifier for resizing Sep 30, 2024
@gdalle gdalle marked this pull request as ready for review September 30, 2024 14:19
@gdalle gdalle merged commit 0f44787 into main Sep 30, 2024
59 checks passed
@gdalle gdalle deleted the gd/adapt_prep branch September 30, 2024 20:21
@gdalle gdalle mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants