Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove noneffectfree per JuliaLang/julia#50313 #172

Merged
merged 1 commit into from
Jun 28, 2023
Merged

remove noneffectfree per JuliaLang/julia#50313 #172

merged 1 commit into from
Jun 28, 2023

Conversation

oxinabox
Copy link
Member

This is follow up to JuliaLang/julia#50313

  • We no longer import things that are not defined
  • We do import the new effect_free_and_nothrow but we don't actually use it (this seemed like correct match to use previously importing effect_free and not using it
  • we stop wrapping an instruction in non_effect_free. Because that is no longer defined and a similar change was made to an instruction in Align meaning for effects and IR flags JuliaLang/julia#50313 so i think it is ok, but i am not sure why it was there in the first place

@oxinabox
Copy link
Member Author

Remaining CI failures are fixed by #171

@oxinabox oxinabox requested a review from aviatesk June 28, 2023 07:05
@aviatesk
Copy link
Member

we stop wrapping an instruction in non_effect_free. Because that is no longer defined and a similar change was made to an instruction in Align meaning for effects and IR flags JuliaLang/julia#50313 so i think it is ok, but i am not sure why it was there in the first place

We recompute statement flags of NewInstruction if it is not given explicitly. non_effect_free utility was used as the alias to NewInstruction(stmt, ..., flag=recompute_stmt_flags(stmt) & ~IR_FLAG_EFFECT_FREE) but it turned out it's not that useful or necessary. For our case recompute_stmt_flag won't give IR_FLAG_EFFECT_FREE for our special statement anyway.

1 similar comment
@aviatesk
Copy link
Member

we stop wrapping an instruction in non_effect_free. Because that is no longer defined and a similar change was made to an instruction in Align meaning for effects and IR flags JuliaLang/julia#50313 so i think it is ok, but i am not sure why it was there in the first place

We recompute statement flags of NewInstruction if it is not given explicitly. non_effect_free utility was used as the alias to NewInstruction(stmt, ..., flag=recompute_stmt_flags(stmt) & ~IR_FLAG_EFFECT_FREE) but it turned out it's not that useful or necessary. For our case recompute_stmt_flag won't give IR_FLAG_EFFECT_FREE for our special statement anyway.

@oxinabox oxinabox merged commit 759f58d into main Jun 28, 2023
@oxinabox oxinabox deleted the ox/nononef branch June 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants