allow AbstractVector input for gradients

JuliaDiff · Feb 9, 2016 · 58f9370 · jrevels · Feb 9, 2016 · 58f9370
1 parent 675818e
commit 58f9370
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/api/gradient.jl b/src/api/gradient.jl
@@ -4,13 +4,13 @@
 
 # Exposed API methods #
 #---------------------#
-@generated function gradient!{T,A}(output::Vector{T}, f, x::Vector, ::Type{A}=Void;
+@generated function gradient!{T,A}(output::AbstractVector{T}, f, x::AbstractVector, ::Type{A}=Void;
                                    chunk_size::Int=default_chunk_size,
                                    cache::ForwardDiffCache=dummy_cache)
     if A <: Void
-        return_stmt = :(gradient!(output, result)::Vector{T})
+        return_stmt = :(gradient!(output, result)::AbstractVector{T})
     elseif A <: AllResults
-        return_stmt = :(gradient!(output, result)::Vector{T}, result)
+        return_stmt = :(gradient!(output, result)::AbstractVector{T}, result)
     else
         error("invalid argument $A passed to FowardDiff.gradient")
     end
@@ -21,7 +21,7 @@
     end
 end
 
-@generated function gradient{T,A}(f, x::Vector{T}, ::Type{A}=Void;
+@generated function gradient{T,A}(f, x::AbstractVector{T}, ::Type{A}=Void;
                                   chunk_size::Int=default_chunk_size,
                                   cache::ForwardDiffCache=dummy_cache)
     if A <: Void
@@ -43,14 +43,14 @@ function gradient{A}(f, ::Type{A}=Void;
                      chunk_size::Int=default_chunk_size,
                      cache::ForwardDiffCache=ForwardDiffCache())
     if mutates
-        function g!(output::Vector, x::Vector)
+        function g!(output::AbstractVector, x::AbstractVector)
             return ForwardDiff.gradient!(output, f, x, A;
                                          chunk_size=chunk_size,
                                          cache=cache)
         end
         return g!
     else
-        function g(x::Vector)
+        function g(x::AbstractVector)
             return ForwardDiff.gradient(f, x, A;
                                         chunk_size=chunk_size,
                                         cache=cache)
@@ -61,15 +61,15 @@ end
 
 # Calculate gradient of a given function #
 #----------------------------------------#
-function _calc_gradient{S}(f, x::Vector, ::Type{S},
+function _calc_gradient{S}(f, x::AbstractVector, ::Type{S},
                            chunk_size::Int,
                            cache::ForwardDiffCache)
     X = Val{length(x)}
     C = Val{chunk_size}
     return _calc_gradient(f, x, S, X, C, cache)
 end
 
-@generated function _calc_gradient{T,S,xlen,chunk_size}(f, x::Vector{T}, ::Type{S},
+@generated function _calc_gradient{T,S,xlen,chunk_size}(f, x::AbstractVector{T}, ::Type{S},
                                                         X::Type{Val{xlen}},
                                                         C::Type{Val{chunk_size}},
                                                         cache::ForwardDiffCache)