Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LU-factorize without pivoting for inv of Taylor1 matrices #223

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Sep 6, 2019

This PR adds a specialized methods of inv for matrices with Taylor1 coefficients, which avoids pivoting in lu. This is related to recent changes (JuliaLang/julia#32989) in Julia stdlib/LinearAlgebra, which now uses pivoting by default.

Fixes #221

@lbenet
Copy link
Member Author

lbenet commented Sep 6, 2019

@KristofferC @andreasnoack Would this be a good solution for #221?

@coveralls
Copy link

coveralls commented Sep 6, 2019

Coverage Status

Coverage decreased (-0.06%) to 93.514% when pulling 0bc4833 on lb/issue221 into b55f183 on master.

@andreasnoack
Copy link
Member

I think specializing lu would be better since it's more general.

@lbenet
Copy link
Member Author

lbenet commented Sep 6, 2019

Thanks for the advice! Just pushed a new commit doing it.

@lbenet
Copy link
Member Author

lbenet commented Sep 6, 2019

@dpsanders Tests are passing, including Julia nightly. Do you agree in merging this?

@dpsanders dpsanders merged commit 7e3801f into master Sep 6, 2019
@dpsanders
Copy link
Contributor

Great, thanks a lot! We should maybe do something similar for interval matrices (although maybe there are other options to consider there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heads up about changes in Julia LinearAlgebra stdlib affecting this package
4 participants