Refactor hash table generation. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpsanders
force-pushed
the
refactor_hash_tables
branch
2 times, most recently
from
c5f37d8 to
97259e0
Compare
|
Can you also rebase this PR? While I like a lot the new implementation of the tables, I'm checking if it can be optimized a bit more. In my machine, the Fatemann tests (julia 0.4) lasts 3.84 sec, versus Mathematica 3.17, so we are within 20%. |
|
In my next work I have gained another factor of 2.5 ;) I'll put it up as a new PR, but I am having problems rebasing this one... |
|
Tests are currently failing due to some recent change JuliaLang/julia#12285. Shall I try to fix this and incorporate the modifications in the tests? |
|
I have fixed the FactCheck syntax, that has changed from |
- Rename generateTables -> generate_tables and refactor to take number of variables and order as arguments - Refactored hash table generation. - Removed explicit tests of hash tables since the exact generation has now changed. - Add blank lines in parameters.jl - Remove unnecessary information from TaylorSeries.jl - Make set_variables accept only strings; fix test - Make index_table an array instead of a dictionary. This significantly improves performance - Fix bug in generate_tables
Add check to fateman Refactored fateman
Fix Euler test
lbenet
force-pushed
the
refactor_hash_tables
branch
from
8b18cbb to
fffd0f0
Compare
|
Rebase and squash is done... Tests pass, so I'm merging. |
lbenet
added a commit
that referenced
this pull request
Jul 31, 2015
Refactor hash table generation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a drop-in replacement for the previous version except that the exact order
in which each set of indices is generated is changed.
The performance is basically the same as in the previous version.EDIT: The performance is now significantly better: 8.4s instead of 12s for the first Fateman test on my machine!
Follows on from #22