-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip out $$ as well #1426
Strip out $$ as well #1426
Conversation
Thanks for adopting that PR 😄 A few things to think about before we merge:
|
I agree with 1. and 4, these are addressed in the new version of the PR About 2. and 3., I agree with
The new version of the PR is non-breaking for cases where it is not wrapped by brackets or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM, just the test examples need fixes. I think we'll merge this after 0.25.3 is tagged.
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Thanks again for adopting and iterating on this @blegat! |
Rebases #1283 and strips
$$
as wellEdit by @mortenpi: close #1283, fix #1278