Fix JuliaMono CSS to support all weights/variants #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous CSS file only supported JuliaMono Regular, which could create some spacings issues (see #1780). Now light/bold/italic font variations should use the proper font files, instead of faux-bolding/italicizing.
|
Thanks, LGTM! Would you mind adding a note into |
|
@mortenpi Like so? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1780. Previous CSS file only supported JuliaMono Regular, which could create some spacings issues (see FedeClaudi/Term.jl#46, for example). Now light/bold/italic font variations should use the proper font files, instead of faux-bolding/italicizing. Also updates JuliaMono source to v0.044 (up from v0.039). Tested on MacOS with Safari, and all font weights/variants worked correctly☺️