set IO context for doctest output relative to sandbox module #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
pushed a commit
that referenced
this pull request
Oct 2, 2018
(cherry picked from commit 98d5c59)
|
LGTM, thanks! I would suggest bumping Documenter in JuliaLang/julia#29470 and merging that to get this onto master. @fredrikekre? But I will also backport this to 0.19. |
Merged
mortenpi
pushed a commit
that referenced
this pull request
Oct 3, 2018
Unlike the original patch, this creates a local unwrapiocontext function that is necessary for this to work on 0.6, as Base.unwrapcontext was introduce in 0.7. (cherry picked from commit 98d5c59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we make a change like JuliaLang/julia#29466, this will be needed. Should be safe now as well.