Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: Fix newline inside escapeinside #38

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

sebastianpech
Copy link
Contributor

In #30 I added the extra escaping of \n in escapeinside to preserve the newlines when displayed in lstlisting. I recently noticed, that this messes with the line counter of listings.

This fixes that behavior by printing each line separately, if it contains \n, and add the linebreak on the level of the listings env.

Old / New
image image

@sebastianpech
Copy link
Contributor Author

Maybe it's actually a good idea to escape all whitespace charaters like that, because they mean something completely different inside of escapeinside. Also listings has special controls for some of them e.g. tab size or tab printing can be controlled. However, the characters need to be placed directly in lstlisting for that.

@sebastianpech
Copy link
Contributor Author

Old

image

New

image

@sebastianpech
Copy link
Contributor Author

Bump @mortenpi

@mortenpi
Copy link
Member

Apologies for neglecting this, thanks for the bump! LGTM as far as I can tell. Nothing breaking here, right?

@mortenpi mortenpi added the bug label Oct 21, 2019
@mortenpi mortenpi added this to the 0.4.5 milestone Oct 21, 2019
@sebastianpech
Copy link
Contributor Author

No thing. Nope nothing breaking.

@mortenpi mortenpi merged commit 6711d45 into JuliaDocs:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants