Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelaunayTriangulation example #1086

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

DanielVandH
Copy link
Contributor

As discussed @Datseris, this PR adds an example using DelaunayTriangulation.jl to simulate a cell model. The model has changed from what it used to be in DelaunayTriangulation.jl's, and now simulates interactions between three cell species and also includes cell death. This was my first time actually using the package so maybe some things are not done optimally.

Here's what the final video looks like.

delaunay_model.mp4

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (8b5b456) to head (e649674).
Report is 151 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1086       +/-   ##
===========================================
+ Coverage   70.12%   85.84%   +15.72%     
===========================================
  Files          42       36        -6     
  Lines        2718     2530      -188     
===========================================
+ Hits         1906     2172      +266     
+ Misses        812      358      -454     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/Project.toml Outdated Show resolved Hide resolved
@Tortar
Copy link
Member

Tortar commented Oct 7, 2024

Very cool model!! My only concern is about plotting, is there a way to reuse more of the Agents.jl infrastructure for it?

Co-authored-by: Adriano Meligrana <68152031+Tortar@users.noreply.github.com>
@Datseris Datseris self-requested a review October 7, 2024 14:04
@Datseris
Copy link
Member

Datseris commented Oct 7, 2024

I'd like to review this before merging. Bit busy at the moment but will find time for sure.

@DanielVandH
Copy link
Contributor Author

DanielVandH commented Oct 7, 2024

Very cool model!! My only concern is about plotting, is there a way to reuse more of the Agents.jl infrastructure for it?

Maybe? I could have made the animation simpler and just not show the data graphs so that abmvideo works. But it seemed like a nice way to also demonstrate how that could be done.

If there's a way to change the recipe used in abmplot (e.g. something other than scatter or poly), then it will also be a lot simpler since I could use voronoiplot. (As mentioned I've not used this package previously so I'm sure there's room for improvement 😅 )

examples/delaunay.jl Outdated Show resolved Hide resolved
DanielVandH and others added 5 commits October 7, 2024 15:40
Co-authored-by: Adriano Meligrana <68152031+Tortar@users.noreply.github.com>
@Tortar
Copy link
Member

Tortar commented Oct 9, 2024

To me, this seems fine, just wait for the review of @Datseris to be merged :-)

@Tortar
Copy link
Member

Tortar commented Oct 28, 2024

@Datseris do you have the time ro review this? Otherwise we could merge it and push updates in the future

@Datseris
Copy link
Member

I'm sorry, I am in a difficult time in life now with no time to spare. I wanted to review because I am convinced we can simplify ploitting, but I don't have the time to do it now. GO ahead and merge and in the future maybe I can make a PR myself!

@Tortar
Copy link
Member

Tortar commented Oct 30, 2024

no problem, I'm also running a bit out of time these days, after graduation I have a bit more frenetic routine :D

If I find the time I will try to update the plotting part, but I don't want to put this onhold because I think it's a great contribution

@Tortar Tortar merged commit 674e913 into JuliaDynamics:main Oct 30, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants