Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add length support #102

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Aug 11, 2024

Adds a keyword argument length=ex to allow for specifying the
length of the iterator.

Closes #41

Adds a keyword argument `length=ex` to allow for specifying the
length of the iterator.

Closes JuliaDynamics#41
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@3f7d845). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/macro.jl 59.52% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage          ?   79.78%           
=========================================
  Files             ?        6           
  Lines             ?      455           
  Branches          ?        0           
=========================================
  Hits              ?      363           
  Misses            ?       92           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member

Thank you! This looks great. The failure on Julia nightly is due to how the @doc test is written (it is a bit fragile). I will make an issue about it and merge this.

@Krastanov Krastanov merged commit 38e14b8 into JuliaDynamics:master Sep 8, 2024
21 of 22 checks passed
@thofma thofma deleted the th/itinterface branch September 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Length of iterators
3 participants