Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Setfield to 0.8, (keep existing compat) #216

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Setfield package from 0.5.1, 0.6, 0.7 to 0.5.1, 0.6, 0.7, 0.8.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@tkf tkf force-pushed the compathelper/new_version/2021-09-18-03-27-06-270-02209724754 branch from 7861fd4 to 82ab463 Compare September 18, 2021 03:27
@tkf tkf enabled auto-merge (squash) September 18, 2021 03:29
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #216 (82ab463) into master (a104913) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.05%     
==========================================
  Files          22       22              
  Lines         519      533      +14     
==========================================
+ Hits          471      484      +13     
- Misses         48       49       +1     
Flag Coverage Δ
unittests 90.80% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/base.jl 83.46% <0.00%> (-0.41%) ⬇️
src/collectors.jl 100.00% <0.00%> (ø)
src/NoBang/singletonof.jl 100.00% <0.00%> (ø)
src/NoBang/base.jl 89.53% <0.00%> (+0.24%) ⬆️
src/dataframes_impl.jl 93.47% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a104913...82ab463. Read the comment docs.

@tkf tkf merged commit a7c9e5e into master Sep 18, 2021
@tkf tkf deleted the compathelper/new_version/2021-09-18-03-27-06-270-02209724754 branch September 18, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant