Improve inferrability of setproperty!!
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's help the inference until `name` is lifted to the type domain. Adding `@inline` to the old implementation was enough. But it's better to use the constructor directly to relying another constprop.
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 23 23
Lines 536 536
=======================================
Hits 490 490
Misses 46 46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's help the inference until
nameis lifted to the type domain.Adding
@inlineto the old implementation was enough. But it's betterto use the constructor directly to relying another constprop.
close #226