Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat #234

Merged
merged 1 commit into from
Sep 20, 2022
Merged

update compat #234

merged 1 commit into from
Sep 20, 2022

Conversation

oscardssmith
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #234 (8889962) into master (c93fe75) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   91.41%   91.52%   +0.10%     
==========================================
  Files          23       23              
  Lines         536      531       -5     
==========================================
- Hits          490      486       -4     
+ Misses         46       45       -1     
Flag Coverage Δ
unittests 91.52% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dataframes_impl.jl 92.85% <0.00%> (-0.63%) ⬇️
src/base.jl 85.03% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BioTurboNick
Copy link

@tkf Can this be merged?

@chriselrod
Copy link

@tkf bump?

@oscardssmith
Copy link
Contributor Author

@DilumAluthge bump?

@DilumAluthge
Copy link
Member

I don't have the commit bit here, but I'll try to ping @tkf on Slack.

@tkf tkf merged commit 7e82568 into JuliaFolds:master Sep 20, 2022
@tkf
Copy link
Member

tkf commented Sep 20, 2022

Sorry I'm late to review this. Releasing: JuliaRegistries/General#68628

@oscardssmith oscardssmith deleted the patch-1 branch September 20, 2022 12:01
@oscardssmith
Copy link
Contributor Author

thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants