Skip to content

Commit

Permalink
Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962
Browse files Browse the repository at this point in the history
 (#419)

* Update to JuliaTesting/Aqua.jl#32
* Don't call test_ambiguities with Base in julia >= 1.6.0-DEV.816
  • Loading branch information
tkf authored Sep 6, 2020
1 parent 754d500 commit b1e469e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/environments/jl10/Manifest.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[[Aqua]]
deps = ["Pkg", "Test"]
git-tree-sha1 = "2c366fa12569d9232b5b7cfa37c36f3f1b2665b2"
git-tree-sha1 = "0ce3be2271a966746ea05caf493edf45162cce1b"
repo-rev = "master"
repo-url = "https://github.com/tkf/Aqua.jl.git"
uuid = "4c88cf16-eb10-579e-8560-4a9242c79595"
version = "0.4.4-DEV"
version = "0.4.5-DEV"

[[ArgCheck]]
git-tree-sha1 = "59c256cf71c3982484ae4486ee86a3d7da891dea"
Expand Down
4 changes: 2 additions & 2 deletions test/environments/main/Manifest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

[[Aqua]]
deps = ["Pkg", "Test"]
git-tree-sha1 = "2c366fa12569d9232b5b7cfa37c36f3f1b2665b2"
git-tree-sha1 = "0ce3be2271a966746ea05caf493edf45162cce1b"
repo-rev = "master"
repo-url = "https://github.com/tkf/Aqua.jl.git"
uuid = "4c88cf16-eb10-579e-8560-4a9242c79595"
version = "0.4.4-DEV"
version = "0.4.5-DEV"

[[ArgCheck]]
git-tree-sha1 = "59c256cf71c3982484ae4486ee86a3d7da891dea"
Expand Down
8 changes: 7 additions & 1 deletion test/test_aqua.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,14 @@ using Transducers
# )

@testset "Method ambiguity" begin
if VERSION >= v"1.6.0-DEV.816"
@warn "Ignoring ambiguities from `Base` to workaround JuliaLang/julia#36962"
packages = [Transducers]
else
packages = [Transducers, Base]
end
Aqua.test_ambiguities(
[Transducers, Base],
packages,
exclude = [Base.get, Setfield.set, Setfield.modify, map!],
)
end
Expand Down

0 comments on commit b1e469e

Please sign in to comment.