-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for ChunkSplitters 3.0 #119
Conversation
If one uses the linked PR of ChunkSplitters, all tests are passing locally. |
4342fc0
to
14b6947
Compare
@MasonProtter would be great if you could give this a quick look. Would like to merge and release this in the next couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just some minor nitpicks.
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Apart from the (What one could do is walk over the docs and see if any of the examples could be simplified by using |
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
I'll merge this. We don't have to register the new version right away to maybe make other breaking changes (e.g. related to #124). |
OhMyThreads API Changes:
split
can now be aSplit
orSymbol
.we now re-exportSplit
,Consecutive
,RoundRobin
chunk
,chunk_indices
chunks
orindex_chunks
don't throw a warning about the fact that we auto turn off our internal chunking. instead throw a warning if they set incompatible chunking related kwargs.TODOs:
chunks
orindex_chunks
and also sets@set chunking=true
or other chunking options like@set ntasks=5
etc.