Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rocFFT] Don't perform a copy for each call of FFT #728

Merged
merged 5 commits into from
Jan 30, 2025
Merged

[rocFFT] Don't perform a copy for each call of FFT #728

merged 5 commits into from
Jan 30, 2025

Conversation

amontoison
Copy link
Member

Similar to the PR in CUDA.jl:
JuliaGPU/CUDA.jl#2578

@pxl-th pxl-th merged commit 37e33f2 into JuliaGPU:master Jan 30, 2025
3 checks passed
@amontoison amontoison deleted the rocfft_r2c branch January 31, 2025 00:04
@amontoison
Copy link
Member Author

@pxl-th I just wanted to check and add test that the input ROCArray used in fft are never modified.
It should be fine if rocFFT follows the same rules than cuFFT and FFTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxl-th pxl-th pxl-th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @pxl-th