Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization for multidimensional mapreduce when the non-reduced domain is large. (eg,
sum(CUDA.zeros(Int, 40000, 100), dims=1)
). When there is an independent reduction problem for every thread on the device, a naive loop is more efficient thanreduce_block
because not every thread is doing work at each iteration.Performance tested like:
With
minimum
,findmax
,sum
, andsum(cos, ...
. The performance gain scales with problem size, but I've measured up to 10x speedup (onsum
for size262144, 256
). The test was performed without the current size check to allow all cases.