Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct intrinsics for rem #1041

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Use correct intrinsics for rem #1041

merged 2 commits into from
Jul 19, 2021

Conversation

simonbyrne
Copy link
Contributor

Fixes #1040

@simonbyrne
Copy link
Contributor Author

@vchuravy where should i add some tests?

@vchuravy
Copy link
Member

vchuravy commented Jul 9, 2021

Uhm here https://github.com/JuliaGPU/CUDA.jl/blob/master/test/device/intrinsics/math.jl, but the content seems to have gotten lost?

@vchuravy
Copy link
Member

vchuravy commented Jul 9, 2021

Let me land #1042 first xD

@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #1041 (c8efeed) into master (5614670) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         117      117           
  Lines        7629     7629           
=======================================
  Hits         6097     6097           
  Misses       1532     1532

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5614670...c8efeed. Read the comment docs.

@vchuravy vchuravy requested a review from maleadt July 12, 2021 21:25
@simonbyrne
Copy link
Contributor Author

@vchuravy is this okay?

vchuravy
vchuravy approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right thing to do

@maleadt maleadt merged commit d1c02b7 into JuliaGPU:master Jul 19, 2021
@maleadt
Copy link
Member

maleadt commented Jul 19, 2021

Thanks!

@maleadt maleadt added bugfix This gets something working again. cuda kernels Stuff about writing CUDA kernels. labels Jul 19, 2021
maleadt pushed a commit that referenced this pull request Aug 9, 2021
@simonbyrne @maleadt
Use correct intrinsics for rem (#1041)
a311585
simonbyrne added a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
@simonbyrne
Use correct intrinsics for rem (JuliaGPU#1041)
3d9ae2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@maleadt maleadt Awaiting requested review from maleadt

Assignees
No one assigned
Labels
bugfix This gets something working again. cuda kernels Stuff about writing CUDA kernels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rem uses wrong intrinsic
3 participants
@simonbyrne @vchuravy @maleadt