CUFFT improvements #1313
Merged
CUFFT improvements #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffFessler
reviewed
Jan 10, 2022
- always allow `mul!`, detecting wrong uses for in-place plance - only perform copies of inputs with complex-to-real plans, according to the CUFFT documentation - be more similar to FFTW.jl
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
- Coverage 78.97% 78.82% -0.16%
==========================================
Files 119 119
Lines 8632 8617 -15
==========================================
- Hits 6817 6792 -25
- Misses 1815 1825 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311