Make nonblocking synchronization robust to errors. #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Feb 11, 2022
vchuravy
approved these changes
Feb 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
+ Coverage 77.98% 78.01% +0.03%
==========================================
Files 121 121
Lines 8929 8951 +22
==========================================
+ Hits 6963 6983 +20
- Misses 1966 1968 +2
Continue to review full report at Codecov.
|
tkf
reviewed
Feb 12, 2022
maleadt
force-pushed
the
tb/async_errors
branch
from
a472a0d
to
3693ded
Compare
maleadt
force-pushed
the
tb/async_errors
branch
from
3693ded
to
bacd69a
Compare
|
@maleadt just tried out this branch, as suggested, on the application that was hanging, and all seem to run fine now with Julia 1.7.1 🙂 |
maleadt
added a commit
that referenced
this pull request
Feb 15, 2022
Make nonblocking synchronization robust to errors.
maleadt
added a commit
that referenced
this pull request
Feb 15, 2022
Make nonblocking synchronization robust to errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our nonblocking synchronization relied on CUDA notifying an async condition, but that may never happen if the stream encounters an error. Protect against this by using a timer that periodically queries the stream in a regular way.
Fixes #1366, may reveal something in #1350.
cc @vchuravy @tkf