Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a compatibility shim for errormonitor #1378

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

vchuravy
Copy link
Member

Should fix #1375 on Julia 1.6

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1378 (b238cc5) into master (f7880a3) will increase coverage by 0.76%.
The diff coverage is 62.50%.

❗ Current head b238cc5 differs from pull request most recent head 572d3a9. Consider uploading reports for the commit 572d3a9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   78.02%   78.78%   +0.76%     
==========================================
  Files         121      119       -2     
  Lines        8954     8708     -246     
==========================================
- Hits         6986     6861     -125     
+ Misses       1968     1847     -121     
Impacted Files Coverage Δ
lib/cudadrv/execution.jl 94.82% <ø> (ø)
lib/cudadrv/memory.jl 81.44% <ø> (ø)
lib/cudadrv/pool.jl 86.84% <0.00%> (ø)
src/pool.jl 74.78% <0.00%> (-1.94%) ⬇️
lib/cudadrv/stream.jl 93.58% <94.44%> (ø)
src/array.jl 86.07% <100.00%> (ø)
src/compiler/execution.jl 86.33% <100.00%> (ø)
lib/utils/memoization.jl 80.00% <0.00%> (-1.82%) ⬇️
lib/cudadrv/devices.jl 85.18% <0.00%> (-1.24%) ⬇️
src/compiler/reflection.jl 94.02% <0.00%> (-0.26%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7880a3...572d3a9. Read the comment docs.

@maleadt maleadt changed the base branch from release-3.8 to master February 17, 2022 06:55
@maleadt
Copy link
Member

maleadt commented Feb 17, 2022

This should also exist on master. Rebased, and changed the version condition (@isdefined code is easily forgotten).

@maleadt maleadt merged commit c38ae98 into master Feb 17, 2022
@maleadt maleadt deleted the vc/err_monitor branch February 17, 2022 07:03
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"errormonitor" undefined in julia1.6
2 participants