Limit time held by CUDNN locks. #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They inhibit finalizers, resulting in OOMs.
This is already done by Base.
Locks taken in a finalizer should never be contended, as ReentrantLock inhibits finalizers when they're taken from a non-finalizer task.
|
I've added some small clean-ups: Use of |
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 72.64% 72.70% +0.06%
==========================================
Files 131 131
Lines 9805 9812 +7
==========================================
+ Hits 7123 7134 +11
+ Misses 2682 2678 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for #1461, introduced by #1430. See #1461 (comment) and JuliaLang/julia#38487.