Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1476: Allow any container in copy_cublasfloat #1498

Merged
merged 2 commits into from
May 8, 2022

Conversation

danielwe
Copy link
Contributor

@danielwe danielwe commented May 7, 2022

#1476 was my fault in #1453, terribly sorry about this

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1498 (c254136) into master (07e8bed) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

❗ Current head c254136 differs from pull request most recent head b828e61. Consider uploading reports for the commit b828e61 to get more accurate results

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   77.36%   76.62%   -0.75%     
==========================================
  Files         120      120              
  Lines        9274     9273       -1     
==========================================
- Hits         7175     7105      -70     
- Misses       2099     2168      +69     
Impacted Files Coverage Δ
lib/cusolver/linalg.jl 86.84% <100.00%> (ø)
lib/cutensor/error.jl 27.27% <0.00%> (-64.40%) ⬇️
lib/cudnn/CUDNN.jl 37.50% <0.00%> (-35.94%) ⬇️
lib/cublas/CUBLAS.jl 50.00% <0.00%> (-25.44%) ⬇️
src/utilities.jl 68.91% <0.00%> (-4.06%) ⬇️
lib/cudadrv/CUDAdrv.jl 51.66% <0.00%> (-3.34%) ⬇️
lib/cudadrv/module/linker.jl 68.75% <0.00%> (-3.13%) ⬇️
lib/cudadrv/memory.jl 78.59% <0.00%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e8bed...b828e61. Read the comment docs.

@danielwe danielwe changed the title Fix #1476: accept any (adjoint) CuArray in copy_cublasfloat Fix #1476: Allow and container in copy_cublasfloat May 8, 2022
@danielwe danielwe changed the title Fix #1476: Allow and container in copy_cublasfloat Fix #1476: Allow any container in copy_cublasfloat May 8, 2022
@vchuravy vchuravy merged commit 1a4f790 into JuliaGPU:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants