-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CUDA 12.1 #1793
Conversation
@maleadt We don't need to modify something for CUDA 12.1.0. If all tests passed that's fine 😃
Don't forget to regenerate the wrappers. |
Let me try enabling those.
That's not required? It's a minor version so should be backwards compatible; only if you want to use newer features you need updated headers. Ideally we'd have separate versions for each CUDA version, but that would mean we'd need to decide at precompilation time which toolkit to use, and we currently don't have that. |
Great! they solved the issue in this version 12.1.0.
No, it's not required but it's easier to keep track of when new features were added for the tests. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1793 +/- ##
==========================================
- Coverage 60.23% 59.85% -0.39%
==========================================
Files 147 147
Lines 12086 12086
==========================================
- Hits 7280 7234 -46
- Misses 4806 4852 +46 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cc @amontoison, hopefully this goes smoother than the previous upgrade 🙂
I take it we should be able to remove the workarounds put in place for 12.0 now?