Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSOLVER: Fix workspace size passing. #1890

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 2, 2023

The APIs expect a number of elements, not a number of bytes.

Fixes #1880

The APIs expect a number of elements, not a number of bytes.
@maleadt maleadt added the bugfix This gets something working again. label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.99 🎉

Comparison is base (7eda21f) 60.25% compared to head (b543e7f) 62.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
+ Coverage   60.25%   62.25%   +1.99%     
==========================================
  Files         150      150              
  Lines       12364    12367       +3     
==========================================
+ Hits         7450     7699     +249     
+ Misses       4914     4668     -246     
Impacted Files Coverage Δ
lib/cusolver/dense.jl 96.04% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 594a8b6 into master May 2, 2023
@maleadt maleadt deleted the tb/cusolver_workspace branch May 2, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer overflow error with svd for large matrix
1 participant