Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovelace fixes #1894

Merged
merged 2 commits into from
May 9, 2023
Merged

Lovelace fixes #1894

merged 2 commits into from
May 9, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 3, 2023

Works around #1874, awaiting feedback by @xaellison.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 68.75% and no project coverage change.

Comparison is base (5efc1c2) 62.25% compared to head (f06a52c) 62.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1894   +/-   ##
=======================================
  Coverage   62.25%   62.25%           
=======================================
  Files         150      150           
  Lines       12367    12370    +3     
=======================================
+ Hits         7699     7701    +2     
- Misses       4668     4669    +1     
Impacted Files Coverage Δ
src/sorting.jl 25.27% <68.75%> (+0.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt marked this pull request as ready for review May 8, 2023 12:55
@maleadt maleadt merged commit c62c336 into master May 9, 2023
@maleadt maleadt deleted the tb/lovelace branch May 9, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant