Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Int32 indices in rand kernels. #1969

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Don't use Int32 indices in rand kernels. #1969

merged 1 commit into from
Jun 16, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 16, 2023

Fixes #1963

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +61.96 🎉

Comparison is base (3321fc8) 0.00% compared to head (05009ec) 61.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1969       +/-   ##
===========================================
+ Coverage    0.00%   61.96%   +61.96%     
===========================================
  Files         145      150        +5     
  Lines       12256    12516      +260     
===========================================
+ Hits            0     7756     +7756     
+ Misses      12256     4760     -7496     
Impacted Files Coverage Δ
src/random.jl 63.79% <0.00%> (+63.79%) ⬆️

... and 102 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 505d69f into master Jun 16, 2023
@maleadt maleadt deleted the tb/rand_i32 branch June 16, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange rand errors when sampling large matrices
1 participant