Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enzyme to test dependencies #1992

Closed
wants to merge 1 commit into from
Closed

Add Enzyme to test dependencies #1992

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jul 7, 2023

@vchuravy
Copy link
Member Author

vchuravy commented Jul 7, 2023

@wsmoses one challenge here is that this causes CUDA and Enzyme to be tightly coupled via CI and Enzyme.jl tends to lag a bit behind in LLVM and GPUCompiler uptakes...

RN this means that JuliaGPU/KernelAbstractions.jl#382 has not been tested on any of KAs GPU backend and I don't think we can add it as a test-dependency to CUDA.jl

Not sure what the right solution here is, maybe a special CI job on KA that installs both Enzyme and CUDA? @maleadt any thoughts?

@vchuravy vchuravy marked this pull request as draft July 7, 2023 19:35
@vchuravy
Copy link
Member Author

vchuravy commented Jul 7, 2023

Of course the same issue comes up in #1869

@wsmoses
Copy link
Contributor

wsmoses commented Jul 7, 2023

We do try to stay as up to date as possible, and have kept up fast historically, but the recent breaking changes (specifically the LLVM context change) has been particularly troublesome to change everywhere...

@maleadt
Copy link
Member

maleadt commented Jul 10, 2023

I don't think Enzyme as a test dep is great, because of the aforementioned compatibility issues. Maybe we could hack it in though, as a special testset that requires additional dependencies (installed by CI, with the ability to ignore installation failures like we do on GPUCompiler.jl).

Or maybe this could go into the tests of the extension package that #1869 should add? (Can extension packages even have tests?)

@vchuravy vchuravy closed this Jul 11, 2023
@vchuravy vchuravy deleted the vc/enzyme branch July 11, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants