Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NVTX events to the integrated profiler. #2043

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 18, 2023

@simonbyrne I force-active NVTX.jl in here because it otherwise doesn't automatically (JuliaGPU/NVTX.jl#32). Do you have plans to resolve JuliaGPU/NVTX.jl#32, or should we make this kind of force-activation an official API?

Depends on JuliaGPU/NVTX.jl#34

@maleadt maleadt added enhancement New feature or request cuda kernels Stuff about writing CUDA kernels. labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 93.50% and project coverage change: +0.12% 🎉

Comparison is base (6ad7a8c) 70.83% compared to head (a8babe5) 70.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
+ Coverage   70.83%   70.96%   +0.12%     
==========================================
  Files         157      157              
  Lines       13852    13912      +60     
==========================================
+ Hits         9812     9872      +60     
  Misses       4040     4040              
Files Changed Coverage Δ
lib/cupti/wrappers.jl 75.40% <ø> (ø)
src/CUDA.jl 100.00% <ø> (ø)
src/profile.jl 82.35% <93.24%> (+2.68%) ⬆️
src/initialization.jl 55.17% <100.00%> (+1.60%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt marked this pull request as ready for review August 21, 2023 09:07
@maleadt maleadt merged commit 5af1a7a into master Aug 21, 2023
@maleadt maleadt deleted the tb/profile_nvtx branch August 21, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda kernels Stuff about writing CUDA kernels. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should NVTX.jl always be active?
1 participant