-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Ref mutable on the GPU. #2109
Conversation
Looking into the failures, the problem is that So we need to do something different based on the assumed user's intent. Either we differentiate based on |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2109 +/- ##
===========================================
- Coverage 72.34% 60.49% -11.85%
===========================================
Files 159 154 -5
Lines 14513 14043 -470
===========================================
- Hits 10500 8496 -2004
- Misses 4013 5547 +1534
☔ View full report in Codecov by Sentry. |
As requested by @utkarsh530:
I'm not convinced we want this, because it requires additional API operations when launching a kernel (to pin the memory). Right now, we are essentially passing the Ref as a Tuple, which doesn’t require any API operations, but makes it immutable of course. It's for the same reason that we don't support nested containers.
Fixes #267