Add extension package for StaticArrays #2273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to @device_override a particular throw-method in StaticArrays to make it GPU-compatible.
This is done like in
src/device/quirks.jl
, but placed in a new extension package for StaticArrays as suggested by @maleadt here.@maleadt do I understand you right that the idea is to also make KernelAbstractions a weak dependency? This would have to be done as part of this PR then I guess?
Otherwise I'm unsure how having StaticArrays as both, a direct dependency (due to the fact it's used in the KA backend code) and an extension package (as introduced here) would work out.For now I'm directly including the code, albeit it still lives in
ext/
.The test (actual test and the file layout) is just a suggestion. I'm not familiar with CUDA.jl's test setup, and I always have a bit of an issue with code loading when dev-installing a package that has extension packages.