Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default buffer size in CUSPARSE mm! functions #2298

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

lpawela
Copy link
Contributor

@lpawela lpawela commented Mar 20, 2024

This solves the issues mentioned in #2296

@amontoison
Copy link
Member

amontoison commented Mar 20, 2024

Can you add a comment to quickly explain why we use a default value 10000 for these routines and tests with your examples that were failing before this PR?

@maleadt maleadt requested a review from amontoison March 21, 2024 08:10
Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lpawela!

lib/cusparse/generic.jl Outdated Show resolved Hide resolved
lib/cusparse/generic.jl Outdated Show resolved Hide resolved
lib/cusparse/generic.jl Outdated Show resolved Hide resolved
[skip ci]

Co-authored-by: Alexis Montoison <35051714+amontoison@users.noreply.github.com>
@maleadt maleadt merged commit ad5ddf8 into JuliaGPU:master Mar 21, 2024
1 check was pending
@maleadt maleadt linked an issue Mar 21, 2024 that may be closed by this pull request
4 tasks
@lpawela lpawela deleted the lp/sparse-buffer-size branch March 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplying CuSparseMatrixCSC by CuMatrix results in Out of GPU memory
3 participants