Fix performance of indexing unified memory. #2340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the goal of #2335 was to improve the performance of deriving a CPU pointer from a unified memory object, i.e., to speed up indexing of
CuArray
s on the CPU. I did a typo resulting in actually regressing that performance, so this brings it back to the expected improvement.Before #2335:
After #2335 + this PR:
This starts to make it possible, I think, to actually use CPU functionality with unified
CuArray
s.