Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the simple exception flag to an info struct that can contain much more information.
I then use it to:
Fixes #1780, #2341, significantly improving the output.
Before:
After:
Note that this still doesn't cover all exception generating sites though, e.g., if code does
throw(BoundsError())
and we don't have a quirk that provides additional exception information, we still report a simpleException
. An IR-level transformation to recover that info would be great, but we currently don't have the tooling for that in GPUCompiler.