Address a corner case when establishing p2p access #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Aug 6, 2024
|
I take it you were running with multiple threads? A lock would be useful then, but it can't hurt handling this corner case gracefully too. |
Co-authored-by: Tim Besard <tim.besard@gmail.com>
No, I didn't run with multiple threads. I tried twice and with the fix here I can see two warnings printed. |
|
Huh, I'm not entirely sure how this happens then. In any case, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly to fix the issue I reported here: JuliaGPU/NCCL.jl#58
I think a better approach may be adding locks to
peer_access?