Allow disabling the linking of libdevice in CUDACompilerParams #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
requested changes
Jan 8, 2025
| @@ -3,12 +3,14 @@ | |||
| Base.@kwdef struct CUDACompilerParams <: AbstractCompilerParams | |||
| cap::VersionNumber | |||
| ptx::VersionNumber | |||
| link_libdevice::Bool # Used by Reactant.jl | |||
There was a problem hiding this comment.
We're using @kwdef
Suggested change
| link_libdevice::Bool # Used by Reactant.jl | |
| # for Reactant.jl, which raises NVVM intrinsics to MLIR | |
| link_libdevice::Bool = true |
| end | ||
|
|
||
| CUDACompilerParams(;cap::VersionNumber, ptx::VersionNumber) = CUDACompilerParams(cap=cap, ptx=ptx, link_libdevice=true) |
There was a problem hiding this comment.
Suggested change
| CUDACompilerParams(;cap::VersionNumber, ptx::VersionNumber) = CUDACompilerParams(cap=cap, ptx=ptx, link_libdevice=true) |
Comment on lines
+32
to
+34
| if !job.config.params.link_libdevice | ||
| return # Don't link libdevice, used by Reactant.jl to raise NVVM intrinsics into MLIR | ||
| end |
There was a problem hiding this comment.
Suggested change
| if !job.config.params.link_libdevice | |
| return # Don't link libdevice, used by Reactant.jl to raise NVVM intrinsics into MLIR | |
| end | |
| job.config.params.link_libdevice || return |
|
@gbaraldi one small thing : if the flag is set, can CUDA.jl/src/compiler/compilation.jl Line 25 in c10e7cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to disable the linking of libdevice into the IR.
This is needed because https://github.com/EnzymeAD/Reactant.jl requires the intrinsics and not their linked code to raise LLVM IR into MLIR
I imagine this can only be properly tested downstream