Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing symbols as arguments #2624

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Support passing symbols as arguments #2624

merged 8 commits into from
Jan 20, 2025

Conversation

vchuravy
Copy link
Member

Fix #2590

test/core/execution.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA.jl Benchmarks

Benchmark suite Current: ef043a2 Previous: 3d45d85 Ratio
latency/precompile 45310114342.5 ns 45362897043 ns 1.00
latency/ttfp 6438596204.5 ns 6376155312.5 ns 1.01
latency/import 3055928177.5 ns 3036001837 ns 1.01
integration/volumerhs 9554757 ns 9568516 ns 1.00
integration/byval/slices=1 146812 ns 146875.5 ns 1.00
integration/byval/slices=3 425144 ns 425040 ns 1.00
integration/byval/reference 145073.5 ns 144927 ns 1.00
integration/byval/slices=2 285905 ns 286033 ns 1.00
integration/cudadevrt 103394 ns 103435 ns 1.00
kernel/indexing 14028 ns 14009 ns 1.00
kernel/indexing_checked 14438 ns 14794 ns 0.98
kernel/occupancy 710.4965034965035 ns 698.5298013245033 ns 1.02
kernel/launch 2143.777777777778 ns 2154 ns 1.00
kernel/rand 16493 ns 18303 ns 0.90
array/reverse/1d 19561 ns 19605 ns 1.00
array/reverse/2d 24693 ns 24620 ns 1.00
array/reverse/1d_inplace 10268 ns 10792.666666666666 ns 0.95
array/reverse/2d_inplace 11697 ns 11263 ns 1.04
array/copy 20821 ns 20439 ns 1.02
array/iteration/findall/int 156282 ns 155820 ns 1.00
array/iteration/findall/bool 135469 ns 134569 ns 1.01
array/iteration/findfirst/int 151272.5 ns 154288 ns 0.98
array/iteration/findfirst/bool 153112 ns 153959 ns 0.99
array/iteration/scalar 62418 ns 61548 ns 1.01
array/iteration/logical 201789.5 ns 203707 ns 0.99
array/iteration/findmin/1d 37833.5 ns 38870 ns 0.97
array/iteration/findmin/2d 94064 ns 94333 ns 1.00
array/reductions/reduce/1d 37102 ns 30423 ns 1.22
array/reductions/reduce/2d 46156.5 ns 51457 ns 0.90
array/reductions/mapreduce/1d 34579.5 ns 30142 ns 1.15
array/reductions/mapreduce/2d 51387 ns 51380 ns 1.00
array/broadcast 21494 ns 21382 ns 1.01
array/copyto!/gpu_to_gpu 13433 ns 11620 ns 1.16
array/copyto!/cpu_to_gpu 207930 ns 209662 ns 0.99
array/copyto!/gpu_to_cpu 241266.5 ns 242902.5 ns 0.99
array/accumulate/1d 108319 ns 109331 ns 0.99
array/accumulate/2d 79895.5 ns 80156 ns 1.00
array/construct 1319.35 ns 1280.3 ns 1.03
array/random/randn/Float32 44545 ns 49367 ns 0.90
array/random/randn!/Float32 26197 ns 26244 ns 1.00
array/random/rand!/Int64 27011 ns 27126 ns 1.00
array/random/rand!/Float32 8664 ns 8464.333333333334 ns 1.02
array/random/rand/Int64 29885 ns 35460 ns 0.84
array/random/rand/Float32 12975 ns 12776 ns 1.02
array/permutedims/4d 67507 ns 67483 ns 1.00
array/permutedims/2d 57025 ns 57092.5 ns 1.00
array/permutedims/3d 59258.5 ns 59419.5 ns 1.00
array/sorting/1d 2776912.5 ns 2776311.5 ns 1.00
array/sorting/by 3369451 ns 3367794.5 ns 1.00
array/sorting/2d 1085064 ns 1086101 ns 1.00
cuda/synchronization/stream/auto 1062.8 ns 1013.0833333333334 ns 1.05
cuda/synchronization/stream/nonblocking 6426.6 ns 6507 ns 0.99
cuda/synchronization/stream/blocking 843.1411764705882 ns 807.4622641509434 ns 1.04
cuda/synchronization/context/auto 1170.7 ns 1212.8 ns 0.97
cuda/synchronization/context/nonblocking 6683.4 ns 6677.8 ns 1.00
cuda/synchronization/context/blocking 908.85 ns 948.4545454545455 ns 0.96

This comment was automatically generated by workflow using github-action-benchmark.

test/core/execution.jl Outdated Show resolved Hide resolved
test/core/execution.jl Outdated Show resolved Hide resolved
src/compiler/compilation.jl Outdated Show resolved Hide resolved
lib/cudadrv/execution.jl Outdated Show resolved Hide resolved
src/compiler/execution.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (3d45d85) to head (ef043a2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2624   +/-   ##
=======================================
  Coverage   73.59%   73.60%           
=======================================
  Files         157      157           
  Lines       15226    15223    -3     
=======================================
- Hits        11206    11205    -1     
+ Misses       4020     4018    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/cudadrv/execution.jl Outdated Show resolved Hide resolved
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@vchuravy vchuravy requested a review from maleadt January 19, 2025 18:48
vchuravy and others added 7 commits January 20, 2025 13:39
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tim Besard <tim.besard@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vchuravy vchuravy merged commit 4bec614 into master Jan 20, 2025
3 checks passed
@vchuravy vchuravy deleted the vc/symbol_passing branch January 20, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing Symbol as a an argument fails
2 participants